Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support default model and platform setting from env #1183

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

Wendong-Fan
Copy link
Member

@Wendong-Fan Wendong-Fan commented Nov 15, 2024

Description

Support default model and platform setting from env

update doc

Motivation and Context

close #1157

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan self-assigned this Nov 15, 2024
@Wendong-Fan Wendong-Fan added the enhancement New feature or request label Nov 15, 2024
@Wendong-Fan Wendong-Fan added this to the Sprint 16 milestone Nov 15, 2024
@Wendong-Fan Wendong-Fan marked this pull request as ready for review November 15, 2024 12:50
@Wendong-Fan Wendong-Fan merged commit a9963e2 into master Nov 15, 2024
6 checks passed
@Wendong-Fan Wendong-Fan deleted the default_model_setting branch November 15, 2024 12:52
@lightaime
Copy link
Member

Can we add some emojis to Key Modules and Cookbooks?

README.md Show resolved Hide resolved
@lightaime
Copy link
Member

Can we also add an example of ModelType.DEFAULT and ModelPlatformType.DEFAULT as ollama?

@Wendong-Fan
Copy link
Member Author

Wendong-Fan commented Nov 24, 2024

Can we also add an example of ModelType.DEFAULT and ModelPlatformType.DEFAULT as ollama?

Hey @lightaime , I will update this part to model documentation with our ModelManager feature together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow user to set the default model platform and model type from environment variables
2 participants