Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RolePlaying model setting would be override by default model #1170

Conversation

Wendong-Fan
Copy link
Member

@Wendong-Fan Wendong-Fan commented Nov 10, 2024

Description

remove default self.model setting in RolePlaying, as the empty dict passed to ChatAgent would use the default model set in ChatAgent side

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan linked an issue Nov 10, 2024 that may be closed by this pull request
3 tasks
@Wendong-Fan Wendong-Fan self-assigned this Nov 10, 2024
@Wendong-Fan Wendong-Fan added the bug Something isn't working label Nov 10, 2024
@Wendong-Fan Wendong-Fan added this to the Sprint 16 milestone Nov 10, 2024
@Wendong-Fan Wendong-Fan marked this pull request as ready for review November 10, 2024 10:08
@Wendong-Fan Wendong-Fan merged commit 111143a into master Nov 10, 2024
6 checks passed
@Wendong-Fan Wendong-Fan deleted the fix-RolePlaying-model-setting-would-be-override-by-default-model branch November 10, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[BUG] 0.2.8 the issue of ModelPlatformType.OPENAI_COMPATIBLE_MODEL
1 participant