Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: google scholar toolkit support author assignment #1124

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

Wendong-Fan
Copy link
Member

@Wendong-Fan Wendong-Fan commented Oct 26, 2024

Description

After discussed with @koch3092 , it's necessary to support author assignment to improve performance, so that if there's author value obtained, it would be used for get_author_publications and get_publication_by_title directly

Motivation and Context

close #1121

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan requested a review from koch3092 October 26, 2024 13:02
@Wendong-Fan Wendong-Fan self-assigned this Oct 26, 2024
@Wendong-Fan Wendong-Fan added the enhancement New feature or request label Oct 26, 2024
@Wendong-Fan Wendong-Fan added this to the Sprint 15 milestone Oct 26, 2024
@Wendong-Fan Wendong-Fan linked an issue Oct 26, 2024 that may be closed by this pull request
2 tasks
@Wendong-Fan Wendong-Fan marked this pull request as ready for review October 26, 2024 13:06
Copy link
Collaborator

@koch3092 koch3092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Wendong-Fan LGTM

@Wendong-Fan Wendong-Fan merged commit 34869ce into master Oct 26, 2024
5 of 6 checks passed
@Wendong-Fan Wendong-Fan deleted the google_scholar_polish branch October 26, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature Request] Optimize GoogleScholarTool
2 participants