Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/elm book elm review #827

Merged
merged 9 commits into from
Sep 2, 2022

Conversation

henriquecbuss
Copy link
Member

What issue does this PR close

Closes #809

Changes Proposed ( a list of new changes introduced by this PR)

  • Add elm-review to elm-book
  • Add elm-review on elm-book on our CI and pre-push hook
  • Fix elm-review errors

How to test ( a list of instructions on how to test this PR)

  • Check that elm-book is being reviewed by elm-review on our CI

@netlify
Copy link

netlify bot commented Sep 2, 2022

Deploy Preview for cambiatus-elm-book ready!

Name Link
🔨 Latest commit ca26993
🔍 Latest deploy log https://app.netlify.com/sites/cambiatus-elm-book/deploys/63120d53fab96c0008864db0
😎 Deploy Preview https://deploy-preview-827--cambiatus-elm-book.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 2, 2022

Deploy done!

Name Link
🔨 Latest commit ca26993
🔍 Latest deploy log https://app.netlify.com/sites/cambiatus/deploys/63120d53fe1699000809265c
😎 Deploy Preview https://deploy-preview-827--cambiatus.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@henriquecbuss henriquecbuss marked this pull request as ready for review September 2, 2022 14:08
Copy link
Member

@lucca65 lucca65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

Copy link
Member

@lucca65 lucca65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@henriquecbuss henriquecbuss merged commit 6f09147 into master Sep 2, 2022
@henriquecbuss henriquecbuss deleted the enhancement/elm-book-elm-review branch September 2, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add elm-review to elm-book
2 participants