Fix/complete actions individually #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucca65
approved these changes
Jul 15, 2021
Comment on lines
+510
to
+514
| completionStatus = | ||
| { completed = List.filter .isCompleted objective.actions | ||
| , left = | ||
| List.filter (not << .isCompleted) objective.actions | ||
| |> List.map (\action -> { tries = 0, action = action }) |
There was a problem hiding this comment.
looks much better! gotta love Elm's syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR close
Closes N/A. Minimizes issues like this, which involve limitations from blockchain regarding CPU/resources. For a better explanation, see this excellent comment from @lucca65
Changes Proposed ( a list of new changes introduced by this PR)
When completing an objective, we send 1 transaction per action inside that objective. Instead of sending all of these transactions at the same time, now send one at a time (when we receive a response from the previous one).
How to test ( a list of instructions on how to test this PR)