Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/join with invitation #596

Merged
merged 3 commits into from
Jul 15, 2021
Merged

Fix/join with invitation #596

merged 3 commits into from
Jul 15, 2021

Conversation

henriquecbuss
Copy link
Member

@henriquecbuss henriquecbuss commented Jul 14, 2021

What issue does this PR close

Closes #590

Changes Proposed ( a list of new changes introduced by this PR)

  • After a user signs up through an invite link, redirect them directly to the dashboard instead of back to the invite page
  • Make it easier to have a page that can be accessed either by a logged in user or a guest user
  • Prevent user being redirected to the community selector when they follow an invitation link

How to test ( a list of instructions on how to test this PR)

  1. Log into a community
  2. Follow an invite link for a community that only allows for invited users and that you're not a part of (you can use http://test.staging.cambiatus.io/invite/Zrdow9)
  3. See invitation page, where you can choose to join the community, in which case you should be redirected to the dashboard

Copy link
Member

@lucca65 lucca65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔬

@henriquecbuss henriquecbuss merged commit 0b1e7b7 into master Jul 15, 2021
@henriquecbuss henriquecbuss deleted the fix/join-with-invitation branch July 15, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot join community that requires invite if you're logged in
2 participants