-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/claim card votes #594
Conversation
@lucca65 need your input, how should we go about the following issues:
|
@juramos-2020 might want to see this as well ☝️ |
Hi @victorgdev I updated de figma
You can use "Pending"
I correct the shade of gray that was in a bar. I'am using one gray colo to progress bar and other to text.
I updated too. 😉👍 |
@juramos-2020 we still have one problem to solve, which is for claims that have 7 or 9 verifiers (first and second cards in the photo below) there is bad positioning behavior on the vote type and number of votes. Can you help us on how to go about it? |
i would always hide the votes and show the text only on hover or click on the mobile keep the numbers tho the colors are super self explanatory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bro can you change one translation, please?
There is a pt-BR error here:
the correct one is "Analisadas"
Its also looking weird on the modal, check this out:
It would be nice to have a little margin button after the content of the modal is done:
And lastly, there is one thing that is bothering me... when the claim is approved, we no longer have the tag to say if it was rejected, approved. We still have the filter for "pending" but still its weird to read a "PENDING" text and the claim was actually approved.
What do you folks think about us adding a full bar when its completed? can be full green and the pending can keep disappear
@victorgdev @juramos-2020 lets do a quick call if needed to discuss this, I think we are, again, running in circles
Just for recap, @lucca65 and @juramos-2020 here are the discussed changes to the designs on this feature: - Voting bar:
ELSE - Claim Modal and Detail page:
- Last Change Requests:
|
Have the changes already been made? I did a test now and it's all right with the progress bar in the card and modal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet! 🍬 ✨
Hi @juramos-2020, yes the requested changes are done. |
What issue does this PR close
Closes #559
Changes Proposed ( a list of new changes introduced by this PR)
Implements voting status bar to the claim card
How to test ( a list of instructions on how to test this PR)
/dashboard
or/dashboard/analysis
orprofile/<username>/claims