Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/community info validation #584

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Conversation

henriquecbuss
Copy link
Member

What issue does this PR close

Closes N/A. Issue brought up by Luiz on Slack

Changes Proposed ( a list of new changes introduced by this PR)

These are all regarding the community information page (/community/settings/info)

  • Set community description field as required
  • Show validation errors when clicking save
  • Focus the top-most input that has an error

How to test ( a list of instructions on how to test this PR)

  1. Go to /community/settings/info
  2. Make a field invalid (e.g. empty description, empty name, invalid website url, empty subdomain)
  3. Click save and see if there is an error below the input, and you're automatically scrolled there

Copy link
Member

@lucca65 lucca65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice! I'm working on fixing the event-source digestion of the update contract call!

@henriquecbuss henriquecbuss merged commit e404038 into master Jun 29, 2021
@henriquecbuss henriquecbuss deleted the fix/community-info-validation branch June 29, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants