Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/redirect to welcome page #577

Merged
merged 3 commits into from
Jun 19, 2021

Conversation

henriquecbuss
Copy link
Member

What issue does this PR close

Closes #571

Changes Proposed ( a list of new changes introduced by this PR)

  • Add redirect query parameter to /community/selector, so that users can change communities and stay on the same page
  • Community selector modal now redirects to the same page the user is in, but in another community
  • If a Guest tries to access a community that doesn't exist, they're redirected to the welcome page (https://www.cambiatus.com/welcome or https://www.cambiatus.com/welcome-demo)

How to test ( a list of instructions on how to test this PR)

Testing the redirection on /community/selector:

  1. Log in to a community
  2. Now try going to a community that doesn't exist, in a specific page (e.g. https://thisisntacommunity.staging.cambiatus.io/shop)
  3. You should be redirected to /community/selector
  4. Choose a community
  5. You should land in the community you chose, in the page you chose (/shop)

Testing the redirection on the community selector modal:

  1. Log in to a community
  2. Go to some page (e.g. /shop)
  3. Click on the community selector icon on the top left
  4. Choose another community
  5. Be redirected to that community, on the page you chose (/shop)

Testing the redirection to the welcome page:
Since this depends on the URL, we could only test this if it was deployed on demo 🙁, so look through the code and see if it makes sense

Copy link
Member

@lucca65 lucca65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henriquecbuss henriquecbuss merged commit dae6fa7 into master Jun 19, 2021
@henriquecbuss henriquecbuss deleted the enhancement/redirect-to-welcome-page branch June 19, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect to welcome page on demo and production
2 participants