Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make contact field update according to selection #575

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

henriquecbuss
Copy link
Member

What issue does this PR close

Closes #573

Changes Proposed ( a list of new changes introduced by this PR)

  • Make contact field update according to selection
  • Add a single _ 🤦‍♂️

How to test ( a list of instructions on how to test this PR)

  1. Log in with an account that doesn't have any contacts registered
  2. Go to the dashboard
  3. The contact modal should show up
  4. Try changing the contact type and see the other fields update accordingly

Copy link
Member

@lucca65 lucca65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@lucca65 lucca65 merged commit ef4665d into master Jun 17, 2021
@lucca65 lucca65 deleted the fix/contact-modal-field branch June 17, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On the add contact modal changing the select don't change the input
2 participants