Fix/cookie env #561
Merged
Fix/cookie env #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henriquecbuss
requested review from
lucca65,
adubas,
alanrrb,
andregomesb,
victorgdev and
zederson
lucca65
approved these changes
Jun 9, 2021
Comment on lines
+115
to
+117
| type PreventScroll | ||
| = PreventScrollOnMobile | ||
| | PreventScrollAlways |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR close
Closes N/A
Changes Proposed ( a list of new changes introduced by this PR)
bespiral.userbecomesbespiral.user.stagingon staging,bespiral.user.demoon demo and stays asbespiral.useron prod)How to test ( a list of instructions on how to test this PR)
Before this PR, there was a bug where users who logged on prod would see an error when they'd go to staging or demo. The steps to reproduce that error:
Now, if you do this, you shouldn't see any errors. Note: because cookies behave differently on the netlify deploy, you should test this on staging (at the time of this writing, it's already deployed there)