Feature/claim modal

[victorgdev]

What issue does this PR close

Closes #536, closes #383

Changes Proposed ( a list of new changes introduced by this PR)

Currently, a claim is displayed in an specific page when a claim card is clicked by the user. The proposed change displays all of the detailed information apparent in the claim specific page in a modal.

Pages that display claim cards (.../claims, .../dashboard, .../dashboard/analysis) will have this feature. When user onClicks a claim card a modal with detailed information of the clicked claim will pop-up.

How to test ( a list of instructions on how to test this PR)

1. Go to each of these pages:

• .../claims
• .../dashboard
• .../dashboard/analysis

2. Find the list of claims
3. Click on a claim card of your choice
4. Open claim modal

Here is the figma design

[lucca65]

The build is failing @victorgdev

[henriquecbuss]

@victorgdev please make sure your files are formatted with elm-format (the CI/CD pipeline will fail if they aren't)

I haven't tested it yet because the build is failing, but here are some comments on the code itself

[victorgdev]

I will redo the elm-format command to fix the build failing!

[lucca65]

bro looking at the code it still have some "basic" issues, like functions commented all over the place, no elm-format. I would consider this a draft pull request because its not "review ready". Its ok to be like that but please consider those like a "basic checklist" before asking for a review. If its still not ready (ready in the sense I'm presenting here) and you would like a review, its possible to ask for it when its still on draft!

[henriquecbuss]

We were doing some tests/exploratory work yesterday, that's why it has a bunch of things commented out 😅. +1 on marking as draft for now though

[lucca65]

🧑‍🏭

[victorgdev]

Just for note taking purposes and validating rationale @NeoVier. Considering the profile photo onHover pop-up feature the new aspects to be considered in order to have the claim modal displaying this feature properly are:

• How the claim card is related to the claim modal.
• How and what the claim modal receives these lists of profiles.
• In the claim modal the multiple profile photos source and lists (top of the modal, list of voters(approved and disapproved) and list of pending voters).

The goal right now is to:

• Implement the profile photos structure, including all the needed profiles source and lists - Partially done
• Fix how each module receives the claim modal (.../claims, .../dashboard, .../dashboard/analysis)

[lucca65]

I've found some things

1. Elm format is still not running, you actually shouldn't even be allowed to commit without it. @NeoVier any chance you know why husky isn't triggering Elm Format?
   Also, please always check GitHub for those stuff, so we can get this out of the way

2. The "no one" tags is using a different style and font weight then other name tags (check a normal user on the second print). It is also not aligned the same depending on the scenario:

3. PDF looks fine on the card, but when opening a preview it is stretched:

4. We should show the full asset here "1 AIKI" instead of "1". It should take precision into consideration: "1,300 AIKI"

[henriquecbuss]

Elm format is still not running, you actually shouldn't even be allowed to commit without it. @NeoVier any chance you know why husky isn't triggering Elm Format?

Looking at our husky config, it's only running standard and review. Would it make sense to automatically run elm-format (and not just check if it's formatted)?

elm-format is triggered only on the on-push-action, that's why it's triggered on GitHub, but not before pushing

We should show the full asset here "1 AIKI" instead of "1". It should take precision into consideration: "1,300 AIKI"

#383 👀

[lucca65]

Would it make sense to automatically run elm-format (and not just check if it's formatted)?

I don't think so, it should block the commit from the client, not automatically format

[henriquecbuss]

🧹

[lucca65]

just noticed something weird... when i vote for a claim and it fails, the modal is kept open and for some reason become full screen on mobile... i'm using an iPhone

if you need me to help you make some claim break, ping me

[lucca65]

oh also, the design team can already start to test this!

[juramos-2020]

Hi @NeoVier do you have any specific link to test this one?

[henriquecbuss]

@juramos-2020 you can use any of the ones that say "Deploy Preview ready!" (just click on "Details" and it should redirect you to the correct version of the app):

[juramos-2020]

Oi @NeoVier

quando eu acesso esse link que você recomenda eu não consigo realizar ações como: criar ações e objetivos, analisar claims, votar, etc.

O Helton tinha deixado um ambiente de testes pronto em que pudéssemos realizar todas essas funcionalidades do admin e do usuário. Mas parece que esse link acaba não sendo útil pra vocês.

Então queria ver com você como consigo resolver isso? 😅

[henriquecbuss]

@juramos-2020 ele provavelmente preparou uma comunidade pra isso, certo?

Então, esse link te leva por padrão pra comunidade da Cambiatus, mas podes mudar de comunidade no canto superior esquerdo (onde fica o ícone da comunidade atual, no caso a Cambiatus):

Ao clicar no ícone da comunidade, vai abrir um menu de seleção de comunidades, daí basta selecionar a comunidade de testes que o Helton preparou (tem que ser na mesma conta que ele usou, pra ser o admin da comunidade que ele preparou)

[juramos-2020]

Ahhhhhhh!
Entendi o que estava fazendo de errado 😅 (sorry)
Eu estava usando as minhas 12 palavras. Nesse caso eu tenho que usar as 12 palavras dele para ter acesso as comunidades que ele criou 😅
Agora vai dar certo! 💪

[juramos-2020]

The modal it's working 👏😍

I'm just not sure about the status: claim.approved.
I think it's just like: Approved

[victorgdev]

@juramos-2020 and @lucca65 I will check it out.

[lucca65]

@victorgdev this error happens sometimes, its not something you can manage, it happens randomly during some builds. We can safely ignore this!

[henriquecbuss]

🎨

[victorgdev]

@juramos-2020 the claim modal is ready for testing and review.

For your information, the only change made was that when approving a claim via modal, if it fails to be approved the modal closes itself and the error msg is apparent as is.

Also, the "claim.approved" comment made is not to be worried, as @lucca65 pointed out above this is random build error that won't persist on the when deployed.

[juramos-2020]

Hi @victorgdev

I tested the modal with three statuses (approved, pending and reproved). And it is working normally.

Only in the modal with status "reproved" the tag "no one" is not appearing.
If this is also a compilation error that won't persist when implemented, then that's all ok 😉👍

[victorgdev]

Hi @juramos-2020, yes this is precisely the case. Can I merge this PR?

[juramos-2020]

Hi @victorgdev l

About the teste it is all ok. But about the merge PR I don't know how this works.

[victorgdev]

Thanks! I got your back on that @juramos-2020! 💪

[lucca65]

💥