Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix community's website button and cover photo #546

Merged
merged 5 commits into from
May 28, 2021

Conversation

henriquecbuss
Copy link
Member

@henriquecbuss henriquecbuss commented May 28, 2021

What issue does this PR close

Closes N/A

Changes Proposed ( a list of new changes introduced by this PR)

  • Automatically include https:// to community's website if they don't provide it
  • Change default cover photo to use SVGs
  • Show actions as completed on the claim cards (the ones in the analysis page and in the dashboard)

How to test ( a list of instructions on how to test this PR)

  • Edit a community to have a website, but don't include https:// in front of it. If you now log out and go to the "Join" page, you should be able to click the "Visit the website" button and be redirected to the correct website
  • Go to a community that doesn't have a cover photo (e.g. cambiatus), and see if the right one shows up (note that they're slightly different imgs for desktop and mobile - the mobile one is wider)
  • Look for a claim from a completed action that was still pending, and see if it shows as "Completed" instead of "Under Review"

Additional context

  • URL issue reported on Slack by @muguika for the Ticolones community on demo
  • Change cover photo to SVGs requested by @rafachadud on Slack
  • Completed action status requested by @juramos-2020 on Slack

@henriquecbuss henriquecbuss requested a review from lucca65 May 28, 2021 01:48
@henriquecbuss henriquecbuss changed the title Automatically include https:// on community's website Fix community's website button and cover photo May 28, 2021
src/elm/Page/Community/New.elm Outdated Show resolved Hide resolved
@henriquecbuss henriquecbuss requested a review from lucca65 May 28, 2021 13:20
@henriquecbuss
Copy link
Member Author

@lucca65, @juramos-2020 asked for some prints from some features, and one of them was to show the action as completed in the claim cards (the ones in the analysis page and in the dashboard), and I realized that wasn't a thing! It's a quick fix, so I just put it in this PR as well, since it's filled with tiny fixes that should be live before the update 😅

Copy link
Member

@lucca65 lucca65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💣 🔥 !!

@henriquecbuss henriquecbuss merged commit 2ac37ef into master May 28, 2021
@henriquecbuss henriquecbuss deleted the fix/community-website branch May 28, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants