Feature/contact #496

henriquecbuss · 2021-03-19T20:59:24Z

What issue does this PR close

Closes #473, closes #474 and closes #472

Changes Proposed ( a list of new changes introduced by this PR)

Add a modal that asks the user to add a contact information if they don't have any
Update the public profile with the new design, and add the ability to see the user's contacts
Update the private profile with the new design, and add the ability to add/edit own contacts

How to test ( a list of instructions on how to test this PR)

Log into an account that has no contact and see if the modal shows up. Try adding a contact. If the user already has a contact, this shouldn't show up
Go into your private profile and try adding/deleting contacts
Go into someone's public profile and look at their contacts. Test the links to see if they open correctly

* Add basic layout (#473) * Add phone validation (#473) * Fix country select, add date check (#473) * Update graphql * Add Contact (#473) * Rename phone to contact * Use ContactType.list (#473) * Rename phone to contact * Add translations (#473) * Add different inputs for phone/username contact types (#473) * Add country code to contact types that use phone numbers (#473) * Add normalization (#473) * Use ContactType in AddContactModal (#473) * Uses (correct) Countries (#473) * WIP: Update GraphQL bindings * WIP: Add graphql secret and auth token * Better contact validation (#473) * Add large modal option * Display error (#473) * Fix contact modal placeholder for profiles (#473) * Remove unused imports (#473) * Fix mobile design * Use country flags on country select * Fix according to review * Fix queries after signing in * Rename flag icons * Clean up costa rica flag * Use Whatsapp as default contact * Adjust casing * Stop showing contact modal if user already has contacts * Separate contact view and update to Profile.Contact * Remove unused imports, exports and functions * Add and use a port for storing auth token * Add USA phone support * Add validation for instagram and telegram * Move contact logic to Contact.elm * Move graphql query with auth to Auth * Simplify auth queries and mutations * Update GraphQL types * Fix analysis query Add filter to optional args. * Remove Debug.log * Code cleanup * Clean up, create profileSelectionSet in Contact.elm * Change view with RemoteData, fix some I18N * Fix view for Multiple, add I18N * Fix validation for Multiple * Use robinheghan/elm-phone-numbers * Add + before country code * Add docs for LoggedIn init functions * Change placeholder based on country, remove footer text * Show feedback * WIP: Move authToken into LoggedIn and sketch out new query function * Fix according to elm-review * WIP: Change query and mutation signatures, remove authToken from Shared * Fix PaymentHistory init for LoggedIn * Fix bug where user wouldn't be authed after logging in * Update GraphQL * Add Profile.AddContact * Adjust Contact.elm, use RemoteData in AddContact.elm * Fix Multiple view * Add public profile contact styles for mobile * Remove prefixes when converting from Normalized to Basic * Remove unused variable * Add I18N * Use new public profile layout * Fix styles when screen is too small and name is too long * Finish private profile styles, refactor code * Fix styles to be inside container Co-authored-by: Andrey Miskov <amiskov@gmail.com>

* Add basic layout (#473) * Add phone validation (#473) * Fix country select, add date check (#473) * Update graphql * Add Contact (#473) * Rename phone to contact * Use ContactType.list (#473) * Rename phone to contact * Add translations (#473) * Add different inputs for phone/username contact types (#473) * Add country code to contact types that use phone numbers (#473) * Add normalization (#473) * Use ContactType in AddContactModal (#473) * Uses (correct) Countries (#473) * WIP: Update GraphQL bindings * WIP: Add graphql secret and auth token * Better contact validation (#473) * Add large modal option * Display error (#473) * Fix contact modal placeholder for profiles (#473) * Remove unused imports (#473) * Fix mobile design * Use country flags on country select * Fix according to review * Fix queries after signing in * Rename flag icons * Clean up costa rica flag * Use Whatsapp as default contact * Adjust casing * Stop showing contact modal if user already has contacts * Separate contact view and update to Profile.Contact * Remove unused imports, exports and functions * Add and use a port for storing auth token * Add USA phone support * Add validation for instagram and telegram * Move contact logic to Contact.elm * Move graphql query with auth to Auth * Simplify auth queries and mutations * Update GraphQL types * Fix analysis query Add filter to optional args. * Remove Debug.log * Code cleanup * Clean up, create profileSelectionSet in Contact.elm * Change view with RemoteData, fix some I18N * Fix view for Multiple, add I18N * Fix validation for Multiple * Use robinheghan/elm-phone-numbers * Add + before country code * Add docs for LoggedIn init functions * Change placeholder based on country, remove footer text * Show feedback * WIP: Move authToken into LoggedIn and sketch out new query function * Fix according to elm-review * WIP: Change query and mutation signatures, remove authToken from Shared * Fix PaymentHistory init for LoggedIn * Fix bug where user wouldn't be authed after logging in * Update GraphQL * Add Profile.AddContact * Adjust Contact.elm, use RemoteData in AddContact.elm * Fix Multiple view * Add public profile contact styles for mobile * Remove prefixes when converting from Normalized to Basic * Remove unused variable * Add I18N * Use new public profile layout * Fix styles when screen is too small and name is too long * Finish private profile styles, refactor code * Fix styles to be inside container * Add modal footer back Co-authored-by: Andrey Miskov <amiskov@gmail.com>

src/elm/Session/LoggedIn.elm

lucca65

nice!

henriquecbuss · 2021-03-23T17:39:59Z

@heltonlr Can you test this on staging please? It includes the modal you've already tested, and the public/private profile redesign.

The modal is only shown if the user doesn't have any contacts added, and it's set to not show up anymore after 01/01/2022. Is that date fine or should we change it?

@lucca65 The Netlify deploys aren't working with the auth update, it sends an empty password. I'm not sure how it's set up, but maybe we need to define the GRAPHQL_SECRET environment variable on Netlify?

lucca65 · 2021-03-23T17:45:09Z

@NeoVier yeah, I don't know how to do it on netlify actually we need to dig deeper on to this

heltonlr · 2021-03-23T20:31:21Z

@heltonlr Can you test this on staging please? It includes the modal you've already tested, and the public/private profile redesign.

The modal is only shown if the user doesn't have any contacts added, and it's set to not show up anymore after 01/01/2022. Is that date fine or should we change it?

@lucca65 The Netlify deploys aren't working with the auth update, it sends an empty password. I'm not sure how it's set up, but maybe we need to define the GRAPHQL_SECRET environment variable on Netlify?

Sure, I will finish tomorrow and let you know!!

henriquecbuss · 2021-03-24T17:50:03Z

@heltonlr Everything should be fixed now

@lucca65 Should I merge this or do you want to wait for after the auth update? Or should this also include #497?

lucca65 · 2021-03-24T18:11:38Z

we can address #497 right after it! merge on! this deploy will include more stuff 💪

heltonlr · 2021-03-24T18:50:30Z

@heltonlr Everything should be fixed now

@lucca65 Should I merge this or do you want to wait for after the auth update? Or should this also include #497?

Thanks, @NeoVier , awesome job

henriquecbuss and others added 3 commits March 19, 2021 17:52

Add I18N

6bf3aa7

henriquecbuss requested review from lucca65 and amiskov March 23, 2021 12:08

lucca65 reviewed Mar 23, 2021

View reviewed changes

src/elm/Session/LoggedIn.elm Outdated Show resolved Hide resolved

lucca65 previously approved these changes Mar 23, 2021

View reviewed changes

Fix design

80c4745

henriquecbuss dismissed lucca65’s stale review via 80c4745 March 24, 2021 14:25

Use social media colors in tailwind

b208056

henriquecbuss requested a review from lucca65 March 24, 2021 15:56

lucca65 approved these changes Mar 24, 2021

View reviewed changes

henriquecbuss merged commit 0f1ee88 into master Mar 24, 2021

henriquecbuss deleted the feature/contact branch March 24, 2021 18:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/contact #496

Feature/contact #496

henriquecbuss commented Mar 19, 2021 •

edited

Loading

lucca65 left a comment

henriquecbuss commented Mar 23, 2021

lucca65 commented Mar 23, 2021

heltonlr commented Mar 23, 2021

henriquecbuss commented Mar 24, 2021

lucca65 commented Mar 24, 2021

heltonlr commented Mar 24, 2021

Feature/contact #496

Feature/contact #496

Conversation

henriquecbuss commented Mar 19, 2021 • edited Loading

What issue does this PR close

Changes Proposed ( a list of new changes introduced by this PR)

How to test ( a list of instructions on how to test this PR)

lucca65 left a comment

Choose a reason for hiding this comment

henriquecbuss commented Mar 23, 2021

lucca65 commented Mar 23, 2021

heltonlr commented Mar 23, 2021

henriquecbuss commented Mar 24, 2021

lucca65 commented Mar 24, 2021

heltonlr commented Mar 24, 2021

henriquecbuss commented Mar 19, 2021 •

edited

Loading