Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styles to be like Figma #478

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

marcjal
Copy link
Contributor

@marcjal marcjal commented Feb 2, 2021

What issue does this PR close

Closes #165

Changes Proposed ( a list of new changes introduced by this PR)

This PR tends to refactor an actual view to be more like Figma

Captura de Tela 2021-02-02 às 19 21 23

How to test ( a list of instructions on how to test this PR)

  • Login to the platform
  • Open transfer page
  • type something like kar
  • See results

@marcjal marcjal changed the title refactor: update styles to be like Figma Update styles to be like Figma Feb 2, 2021
src/styles/main.css Outdated Show resolved Hide resolved
@marcjal marcjal force-pushed the fix/follow-figma-styles branch from c10c012 to 3af5b9a Compare February 2, 2021 23:00
@marcjal
Copy link
Contributor Author

marcjal commented Feb 2, 2021

@lucca65 an e-mail with a message that ci is failed was sent me, something about slack notification and a webhook

@lucca65 lucca65 requested a review from amiskov February 2, 2021 23:05
Copy link
Member

@lucca65 lucca65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcjal can you move the css classes to around line 104?

We should add a section like this:

/* Elm Select*/

.elm-select-menu .elm-select-item:last-of-type .items-center > .border-dotted {
   border-style: unset
 }

/* End of Elm Select*/

@marcjal marcjal force-pushed the fix/follow-figma-styles branch from 3af5b9a to c374231 Compare February 2, 2021 23:18
@marcjal
Copy link
Contributor Author

marcjal commented Feb 2, 2021

@marcjal can you move the css classes to around line 104?

We should add a section like this:

/* Elm Select*/

.elm-select-menu .elm-select-item:last-of-type .items-center > .border-dotted {
   border-style: unset
 }

/* End of Elm Select*/

sure! let me update it

@lucca65
Copy link
Member

lucca65 commented Feb 2, 2021

@marcjal Thanks so much for the contribution! Its awesome to receive some help! Please let us know if you want to go further deep with it, maybe we have some more challenging issues so you can work on your Elm skills

@marcjal
Copy link
Contributor Author

marcjal commented Feb 2, 2021

@marcjal Thanks so much for the contribution! Its awesome to receive some help! Please let us know if you want to go further deep with it, maybe we have some more challenging issues so you can work on your Elm skills

sure! let's do it xD I would like to continue contributing @lucca65

@marcjal
Copy link
Contributor Author

marcjal commented Feb 2, 2021

for some reason, the build failed. this is normal? @lucca65

@lucca65
Copy link
Member

lucca65 commented Feb 3, 2021

for some reason, the build failed. this is normal? @lucca65

Don't worry ;)

@lucca65 lucca65 merged commit eac766c into cambiatus:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong autocomplete design
2 participants