Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/search 471 #476

Merged
merged 96 commits into from
Feb 15, 2021
Merged

Feature/search 471 #476

merged 96 commits into from
Feb 15, 2021

Conversation

amiskov
Copy link
Contributor

@amiskov amiskov commented Jan 23, 2021

What issue does this PR close

Closes #471

Changes Proposed ( a list of new changes introduced by this PR)

Add a search panel at the top of the website. Make sure that the user can interact with the search results from any page.

How to test ( a list of instructions on how to test this PR)

  • Try to find some offers and actions.
  • Make sure that the empty query is not working.
  • Try to claim found actions.
  • Also, try to claim actions from the community page like /community/2,AMTB since the claiming logic was changed.
  • Click found offers to go to their pages.
  • Try to click the menu links, change the current community and go to the profile (search pannel should disappear and the page content should be shown).
  • Check the mobile and desktop.

@amiskov amiskov self-assigned this Jan 23, 2021
@amiskov amiskov marked this pull request as ready for review February 11, 2021 11:20
Copy link
Member

@lucca65 lucca65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥵 wow super big PR! congratulations for the work @amiskov, you did tons of upgrades and fixes! thanks for it!

some questions, suggestions etc

src/elm/Action.elm Show resolved Hide resolved
src/elm/Action.elm Outdated Show resolved Hide resolved
src/elm/Community.elm Show resolved Hide resolved
src/elm/Page/Community.elm Show resolved Hide resolved
src/elm/Page/Community.elm Show resolved Hide resolved
src/elm/Session/LoggedIn.elm Show resolved Hide resolved
src/elm/Session/LoggedIn.elm Outdated Show resolved Hide resolved
src/elm/Session/LoggedIn.elm Outdated Show resolved Hide resolved
src/elm/Session/LoggedIn.elm Show resolved Hide resolved
src/elm/Session/LoggedIn.elm Show resolved Hide resolved
@amiskov
Copy link
Contributor Author

amiskov commented Feb 12, 2021

This is the reply to this comment.

maybe we can do how we do when opening the profile menu, any outside click renders the whole modal to close, thoughts?

Yeah, we could! But the design for claiming with photo looks more like a page, not like a modal (I clarified this in Slack with @heltonlr).

image

@heltonlr
Copy link

Much information for a modal, so I have chosen using a page.

@amiskov amiskov requested a review from lucca65 February 12, 2021 13:08
Copy link
Member

@lucca65 lucca65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some icons are not rendering (bell, dashboard, shop and my sale icons). Not sure if that's something with our build process or the colors added
Captura de Tela 2021-02-12 às 17 15 20

coloring of icons in the profile dropdown also changed:

Captura de Tela 2021-02-12 às 17 19 01

src/elm/Page/Community.elm Show resolved Hide resolved
src/elm/Ports.elm Show resolved Hide resolved
@amiskov
Copy link
Contributor Author

amiskov commented Feb 15, 2021

Some icons are not rendering (bell, dashboard, shop and my sale icons). Not sure if that's something with our build process or the colors added
Captura de Tela 2021-02-12 às 17 15 20

Thanks for catching this @lucca65! I broke some filling styles while adding some new variations. Should be fixed now.

@amiskov amiskov requested a review from lucca65 February 15, 2021 09:28
Copy link
Member

@lucca65 lucca65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@amiskov amiskov merged commit cb6a6c9 into master Feb 15, 2021
@amiskov amiskov deleted the feature/search-471 branch February 15, 2021 16:29
@lucca65 lucca65 mentioned this pull request Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Search to LoggedIn.
3 participants