-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/search 471 #476
Feature/search 471 #476
Conversation
After changing community and clicking Profile link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥵 wow super big PR! congratulations for the work @amiskov, you did tons of upgrades and fixes! thanks for it!
some questions, suggestions etc
This is the reply to this comment.
Yeah, we could! But the design for claiming with photo looks more like a page, not like a modal (I clarified this in Slack with @heltonlr). |
Much information for a modal, so I have chosen using a page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this @lucca65! I broke some filling styles while adding some new variations. Should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
What issue does this PR close
Closes #471
Changes Proposed ( a list of new changes introduced by this PR)
Add a search panel at the top of the website. Make sure that the user can interact with the search results from any page.
How to test ( a list of instructions on how to test this PR)
/community/2,AMTB
since the claiming logic was changed.