add 400 - Bad Request for invalid session ID in GET & DELETE /sessions/{sessionId} #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxl2287
requested review from
hdamker,
eric-murray and
RandyLevensalor
as code owners
maxl2287
force-pushed
the
add-400-bad-request-get-sessions
branch
from
f4f8662 to
97e5742
Compare
maxl2287
changed the title
maxl2287
force-pushed
the
add-400-bad-request-get-sessions
branch
from
885023d to
97e5742
Compare
maxl2287
changed the title
maxl2287
force-pushed
the
add-400-bad-request-get-sessions
branch
from
97e5742 to
9370b63
Compare
|
@maxl2287 please rebase. Your other PR to fix linting has been merged. I'll provide comments in the ticker per this patch. |
maxl2287
force-pushed
the
add-400-bad-request-get-sessions
branch
from
9370b63 to
a7ead58
Compare
|
@RandyLevensalor done. 🐈⬛ |
maxl2287
changed the title
|
@RandyLevensalor could you do a review again, please ? |
eric-murray
approved these changes
Sep 8, 2023
hdamker
approved these changes
Sep 10, 2023
RandyLevensalor
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
There is no expected behaviour for an malformed Session-Id in the GET- & DELETE-request.
This PR shell add a Bad Request (HTTP 400) for the GET & DELETE /sessions/{sessionId} - endpoint.
Which issue(s) this PR fixes:
Fixes #209