Remove reference to formatting and encoding of operator token values #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garciasolero
requested review from
jpengar,
AxelNennker and
sebdewet
as code owners
AxelNennker
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
It is not necessary to define a specific encoding format for the value of the operator token sent as login_hint in CIBA because it may contain url-unsafe characters. The standard already addresses this issue and states that all parameters must be encoded in
application/x-www-form-urlencoded.Any reference to the encoding of the operator token is removed, just as the other parameters that could contain url-unsafe characters are not mentioned for the same case, as this could lead to misunderstandings by sending a double-encoded parameter.
Which issue(s) this PR fixes:
Fixes #259