Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha release r2.1 #239

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Alpha release r2.1 #239

merged 4 commits into from
Dec 3, 2024

Conversation

jpengar
Copy link
Collaborator

@jpengar jpengar commented Nov 28, 2024

What type of PR is this?

  • subproject management

What this PR does / why we need it:

This is the release PR for the pre-release r2.1 (first alpha release for Spring25) containing version v0.3.0-alpha.1 of ICM

Which issue(s) this PR fixes:

Fixes #235
Fixes #207

It is related to #193

Special notes for reviewers:

This PR includes all the changes in the ICM scope of the Spring25 meta-release that have been merged so far. However, there are still open discussions that will need to be included when consensus is reached.

Changelog input

r2.1 containing version v0.3.0-alpha.1 of ICM

Additional documentation

https://lf-camaraproject.atlassian.net/wiki/spaces/CAM/pages/14551399/Meta-release+Process#Commonalities-and-ICM
https://lf-camaraproject.atlassian.net/wiki/spaces/CAM/pages/14560849/Meta-release+Spring25

@jpengar jpengar requested a review from a team November 28, 2024 12:43
Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
@hdamker
Copy link
Collaborator

hdamker commented Nov 29, 2024

LGTM, just two suggestions:

  • a short mention of the closed PR from @chrishowell in brackets, as this was the base for the PRs with language and readability improvements
  • a note that the mandatory info.description has been changed, and need to be adopted by all API definitions eventually (but maybe now to early, as this is only the alpha version of it)

@jpengar
Copy link
Collaborator Author

jpengar commented Nov 29, 2024

a short mention of the closed PR from @chrishowell in brackets, as this was the base for the PRs with language and readability improvements

@hdamker Of course, most of the work was done by @chrishowell. I was just not sure how to do that in the changelog since the original PR was closed. I can just replace myself with Chris's username. That's perfectly fine with me... If you guys have any suggestions on how to do it, please feel free to add them to the PR.

@hdamker
Copy link
Collaborator

hdamker commented Nov 29, 2024

@hdamker Of course, most of the work was done by @chrishowell. I was just not sure how to do that in the changelog since the original PR was closed. I can just replace myself with Chris's username. That's perfectly fine with me... If you guys have any suggestions on how to do it, please feel free to add them to the PR.

I would not replace your username (that would be confusing when going to the PR) but just mention @chrishowell as well. The PR description is then explaining the authorship.

AxelNennker and others added 2 commits November 30, 2024 09:21
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@AxelNennker AxelNennker merged commit 0c36df8 into main Dec 3, 2024
1 check passed
@jpengar jpengar deleted the jpengar/icm-release-r2.1 branch January 24, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an Alpha Release ICM Release Versioning
5 participants