Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix returned error in authentication code flow #180

Conversation

garciasolero
Copy link
Contributor

What type of PR is this?

  • correction

What this PR does / why we need it:

According to OAuth 2.0 (RFC 6749), if the resource owner denies the request, the response should redirect the user-agent to the client redirection URI by adding the error parameter with access_denied value.

If the resource owner denies the access request or if the request fails for reasons other than a missing or invalid redirection URI, the authorization server informs the client by adding the following parameters to the query component of the redirection URI using the"application/x-www-form-urlencoded" format [...]

Which issue(s) this PR fixes:

Special notes for reviewers:

Changelog input

Additional documentation

Copy link
Collaborator

@jpengar jpengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch! That was a doc typo.

Copy link
Collaborator

@sebdewet sebdewet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@AxelNennker AxelNennker merged commit a9c1f1e into camaraproject:main Jul 17, 2024
@jpengar jpengar mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants