Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include x-correlator #112

Conversation

fernandopradocabrillo
Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo commented Feb 15, 2024

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature

What this PR does / why we need it:

  1. Include header x-correlator
  2. Create parameters and headers sections with x-correlator and subscriptionId to avoid code duplication and allow the reuse of schemas

Which issue(s) this PR fixes:

Fixes #104

Special notes for reviewers:

@bigludo7
Copy link
Collaborator

bigludo7 commented Mar 5, 2024

With the approval of camaraproject/Commonalities#115 I guess we should merge this one correct? (@eric-murray @fernandopradocabrillo @sachinvodafone @akoshunyadi )

bigludo7
bigludo7 previously approved these changes Mar 5, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sachinvodafone
sachinvodafone previously approved these changes Mar 13, 2024
@bigludo7
Copy link
Collaborator

Wait for camaraproject/Commonalities#164 outcomes for x-correlator

@akoshunyadi akoshunyadi added the v0.6.0 Planned for release v0.6.0 label Mar 13, 2024
@fernandopradocabrillo fernandopradocabrillo changed the title include x-correlator and fix typo in 400 error code include x-correlator Mar 13, 2024
bigludo7
bigludo7 previously approved these changes Apr 4, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bigludo7
bigludo7 previously approved these changes Apr 10, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akoshunyadi
akoshunyadi previously approved these changes Apr 11, 2024
@akoshunyadi akoshunyadi dismissed stale reviews from bigludo7 and themself via 255bf7b April 11, 2024 13:41
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akoshunyadi akoshunyadi merged commit 4efdb56 into camaraproject:main Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v0.6.0 Planned for release v0.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include x-correlator header
4 participants