Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.4.0-rc.1 #240

Merged
merged 9 commits into from
Jul 11, 2024
Merged

Release 0.4.0-rc.1 #240

merged 9 commits into from
Jul 11, 2024

Conversation

rartych
Copy link
Collaborator

@rartych rartych commented Jun 24, 2024

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

This is "Release PR" for Commonalities Release 0.4.0-rc.1

Which issue(s) this PR fixes:

Special notes for reviewers:

Changelog input

Commonalities Release 0.4.0-rc.1

Additional documentation

https://wiki.camaraproject.org/display/CAM/Meta-release+Process#MetareleaseProcess-Milestoneactivities

@rartych rartych marked this pull request as ready for review July 3, 2024 07:12
@rartych rartych requested a review from bigludo7 July 3, 2024 07:12
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Contributor

@maxl2287 maxl2287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Show resolved Hide resolved
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanjadegroot
Copy link
Contributor

For the release process, please add @camaraproject/TSC_participants to the reviewers of this PR.

@hdamker hdamker requested a review from a team July 4, 2024 08:20
Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@hdamker hdamker requested a review from a team July 4, 2024 17:04
@hdamker
Copy link
Collaborator

hdamker commented Jul 4, 2024

@rartych @camaraproject/commonalities_maintainers:

Within TSC today (draft minutes) we have decided to keep the release candidate PRs for Commonalities and ICM open until Wednesday, July 10th, for a final review including the TSC participants. So please wait with the merge until then.

Copy link

@diegogonmar diegogonmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PedroDiez PedroDiez requested a review from a team July 5, 2024 07:05
@hdamker hdamker requested a review from a team July 8, 2024 08:05
@hdamker
Copy link
Collaborator

hdamker commented Jul 8, 2024

@camaraproject/tsc-participants thanks for the incoming approvals for the PR. Just adding the team again as GitHub is always happy with the first review/approval from one member of the team and drops it from the reviewer list.

The review is open until Wednesday, July 10th.

@patrice-conil
Copy link
Collaborator

LGTM

Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kevsy
Copy link
Collaborator

Kevsy commented Jul 9, 2024

LGTM

@rartych rartych merged commit f9f6c49 into camaraproject:main Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.