Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Version for M4 #154

Merged
merged 22 commits into from
Mar 6, 2025
Merged

API Version for M4 #154

merged 22 commits into from
Mar 6, 2025

Conversation

FabrizioMoggio
Copy link
Collaborator

release number update to v0.3.0

What type of PR is this?

  • documentation

What this PR does / why we need it:

This PR updates the release version to 0.3.0. Stable release for M4.

Which issue(s) this PR fixes:

#153

@FabrizioMoggio
API Version for M4
ef15648 
release number update to v0.3.0: camaraproject#153
@FabrizioMoggio FabrizioMoggio requested a review from a team February 24, 2025 14:43
hdamker
hdamker reviewed Feb 25, 2025
View reviewed changes
@hdamker
Copy link
Contributor

hdamker commented Feb 25, 2025 •
edited
Loading

@FabrizioMoggio As CallForwardingSignal was promoted to the "Incubating" stage, please do the following changes (either here in the release PR or as a separate issue and PR:

  • Badge "Incubating API Repository" applied in README
  • Text in README aligned with template README.md (see code there for the commented sections)
  • Line "Incubating stage since: February 2025" added

@hdamker hdamker mentioned this pull request Feb 25, 2025
Closed
15 tasks
This was referenced Feb 25, 2025
Closed
Closed
hdamker
hdamker requested changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the PR on the template is still waiting for review and merge, but ProjectStructureAndRoles.md is already updated:

FabrizioMoggio and others added 3 commits February 25, 2025 23:27
@FabrizioMoggio @hdamker
Incubating Repo
98cb4e4 
camaraproject#156

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@FabrizioMoggio @hdamker
Incubating Repo
ca0988b 
camaraproject#156

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@FabrizioMoggio @hdamker
Incubating Repo
2b1fd41 
camaraproject#156

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@FabrizioMoggio
Copy link
Collaborator Author

FabrizioMoggio commented Feb 28, 2025 •
edited
Loading

@hdamker I don't get why Merging is blocked. In my understanding I have included in the PR all the requested changes, Isn't it?
@bigludo7 , @chinaunicomyangfan , as soon as the review is completed (it should already be completed, actually) it will be required also your review, I think

@FabrizioMoggio FabrizioMoggio requested a review from a team February 28, 2025 17:56
hdamker
hdamker requested changes Feb 28, 2025
View reviewed changes
This was referenced Mar 1, 2025
Closed
Closed
Closed
Closed
Closed
@FabrizioMoggio FabrizioMoggio mentioned this pull request Mar 1, 2025
Closed
@FabrizioMoggio FabrizioMoggio mentioned this pull request Mar 1, 2025
Closed
@FabrizioMoggio FabrizioMoggio requested a review from hdamker March 3, 2025 14:01
@FabrizioMoggio FabrizioMoggio mentioned this pull request Mar 4, 2025
Closed
FabrizioMoggio
FabrizioMoggio commented Mar 5, 2025
View reviewed changes
Copy link
Collaborator Author

@FabrizioMoggio FabrizioMoggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is strange, I don't have that void raw in my file. Anyway good catch, thank you

hdamker
hdamker approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my review comments are addressed, so LGTM from release management perspective. As there were a few larger changes, I propose that @bigludo7 and @chinaunicomyangfan are doing a thorough review before the PR is merged (can be done next week).

chinaunicomyangfan
chinaunicomyangfan approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@chinaunicomyangfan chinaunicomyangfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FabrizioMoggio FabrizioMoggio merged commit e5e6ad7 into camaraproject:main Mar 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdamker hdamker hdamker approved these changes

@chinaunicomyangfan chinaunicomyangfan chinaunicomyangfan approved these changes

@bigludo7 bigludo7 Awaiting requested review from bigludo7 bigludo7 is a code owner

Assignees
No one assigned
Labels
Spring25
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FabrizioMoggio @hdamker @chinaunicomyangfan