Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes and improvements for Notifications #173

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

calvinmclean
Copy link
Owner

  • Refactor "water completed" notifications to rename the file and struct to be more relevant
  • Fix version compatibility for hord and babyapi
  • Fix nil pointer when loading GardenModal for a Garden without LightSchedule
  • Move NotificationClientID to the Garden so it can be used by the "water completed" notifications from MQTT
  • Improve tests for NotificationClient "water completed" by using VHS mocks

- If LightSchedule was nil, CompareNotificationClientID would panic,
  so this first checks if it's nil
- Rename file so it is easier to find
- Also improve tests by using VHS for Pushover client
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.20%. Comparing base (a57b73c) to head (75ac031).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   71.80%   72.20%   +0.39%     
==========================================
  Files          52       52              
  Lines        3380     3389       +9     
==========================================
+ Hits         2427     2447      +20     
+ Misses        745      731      -14     
- Partials      208      211       +3     
Components Coverage Δ
garden-app 72.20% <85.71%> (+0.39%) ⬆️

@calvinmclean calvinmclean merged commit 42f5a13 into main Jul 17, 2024
6 checks passed
@calvinmclean calvinmclean deleted the fix/notifications branch July 17, 2024 04:13
calvinmclean added a commit that referenced this pull request Jul 17, 2024
Various fixes and improvements for Notifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant