Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add RN experimental debugger compatibility #508

Merged
merged 15 commits into from
May 6, 2024
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 6 additions & 66 deletions packages/TesterApp/ios/Podfile.lock
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
PODS:
- boost (1.83.0)
- callstack-repack (4.0.0-rc.1):
- callstack-repack (4.0.0-rc.2):
- DoubleConversion
- glog
- hermes-engine
Expand Down Expand Up @@ -1188,69 +1188,9 @@ PODS:
- React-perflogger (= 0.74.0)
- React-utils (= 0.74.0)
- RNCAsyncStorage (1.21.0):
- DoubleConversion
- glog
- hermes-engine
- RCT-Folly (= 2024.01.01.00)
- RCTRequired
- RCTTypeSafety
- React-Codegen
- React-Core
- React-debug
- React-Fabric
- React-featureflags
- React-graphics
- React-ImageManager
- React-NativeModulesApple
- React-RCTFabric
- React-rendererdebug
- React-utils
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- Yoga
- RNSVG (15.2.0-rc.0):
- DoubleConversion
- glog
- hermes-engine
- RCT-Folly (= 2024.01.01.00)
- RCTRequired
- RCTTypeSafety
- React-Codegen
- React-Core
- React-debug
- React-Fabric
- React-featureflags
- React-graphics
- React-ImageManager
- React-NativeModulesApple
- React-RCTFabric
- React-rendererdebug
- React-utils
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- RNSVG/common (= 15.2.0-rc.0)
- Yoga
- RNSVG/common (15.2.0-rc.0):
- DoubleConversion
- glog
- hermes-engine
- RCT-Folly (= 2024.01.01.00)
- RCTRequired
- RCTTypeSafety
- React-Codegen
- React-Core
- React-debug
- React-Fabric
- React-featureflags
- React-graphics
- React-ImageManager
- React-NativeModulesApple
- React-RCTFabric
- React-rendererdebug
- React-utils
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- Yoga
- SocketRocket (0.7.0)
- SwiftyRSA (1.7.0):
- SwiftyRSA/ObjC (= 1.7.0)
Expand Down Expand Up @@ -1443,7 +1383,7 @@ EXTERNAL SOURCES:

SPEC CHECKSUMS:
boost: d3f49c53809116a5d38da093a8aa78bf551aed09
callstack-repack: 642d5e8050dcae87c09824254ac413c7b972c25e
callstack-repack: 7e54e95be6a8e0f1fc6aec6c65438269d1bb1bf6
DoubleConversion: 76ab83afb40bddeeee456813d9c04f67f78771b5
FBLazyVector: 026c8f4ae67b06e088ae01baa2271ef8a26c0e8c
fmt: 4c2741a687cc09f0634a2e2c72a838b99f1ff120
Expand Down Expand Up @@ -1479,9 +1419,9 @@ SPEC CHECKSUMS:
React-perflogger: 271f1111779fef70f9502d1d38da5132e5585230
React-RCTActionSheet: 5d6fb9adb11ab1bfbce6695a2b785767e4658c53
React-RCTAnimation: 86ace32c56e69b3822e7e5184ea83a79d47fc7b9
React-RCTAppDelegate: 72f997b4e418d9db8715f12b2edc002fd583e9ec
React-RCTAppDelegate: 74b45c4e3c1c23db88385d74cf4f5a8500694527
React-RCTBlob: fb91c62a549f004e251235c65c665c6890a923a3
React-RCTFabric: 593660526e2b6b59857acf9585de1247660e9b68
React-RCTFabric: af6b9bc4aa9dfa0af1a1bcf5d8e5c5b1f17ae99c
React-RCTImage: b482f07cfdbe8e413edbf9d85953cecdb569472c
React-RCTLinking: fbd73a66cab34df69b2389c17f200e4722890fd9
React-RCTNetwork: fbdd716fbd6e53feb6d8e00eeb85e8184ad42ac8
Expand All @@ -1497,8 +1437,8 @@ SPEC CHECKSUMS:
React-runtimescheduler: 7fe561d179b97cecd0c2bec0bbd08f9fd8581c26
React-utils: f013537c3371270d2095bff1d594d00d4bc9261b
ReactCommon: 2cde697fd80bd31da1d6448d25a5803088585219
RNCAsyncStorage: 4c86d1ded361808906e400ca3aab68b24f37c36a
RNSVG: 5aca9d537e92d2a0282f69350b5d441f23271e62
RNCAsyncStorage: 618d03a5f52fbccb3d7010076bc54712844c18ef
RNSVG: 55bf7e6e90717321191cde721072df87e9f8a024
SocketRocket: abac6f5de4d4d62d24e11868d7a2f427e0ef940d
SwiftyRSA: 8c6dd1ea7db1b8dc4fb517a202f88bb1354bc2c6
Yoga: ff1d575b119f510a5de23c22a794872562078ccf
Expand Down
6 changes: 5 additions & 1 deletion packages/TesterApp/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { Appearance } from 'react-native';
import { Appearance } from 'react-native'

import { AppContainer } from './ui/AppContainer';
import { Section } from './ui/Section';
Expand All @@ -9,6 +9,7 @@ import { AsyncContainer } from './asyncChunks/AsyncContainer';
import { RemoteContainer } from './remoteChunks/RemoteContainer';
import { MiniAppsContainer } from './miniapp/MiniAppsContainer';
import { AssetsTestContainer } from './assetsTest/AssetsTestContainer';
import DeprecatedRemoteDebuggerContainer from './deprecatedRemoteDebugger/DeprecatedRemoteDebuggerContainer'

Appearance.setColorScheme('light');

Expand All @@ -28,6 +29,9 @@ const App = () => {
<Section title="Assets test">
<AssetsTestContainer />
</Section>
<Section title="Deprecated remote debugger">
<DeprecatedRemoteDebuggerContainer />
</Section>
</SectionContainer>
</AppContainer>
);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import { Button } from '../ui/Button'
// @ts-ignore
import NativeDevSettings from 'react-native/Libraries/NativeModules/specs/NativeDevSettings';


export default function DeprecatedRemoteDebuggerContainer () {
return (
<>
<Button title={'Open remote debugger'} onPress={() => NativeDevSettings.setIsDebuggingRemotely(true)} />
<Button title={'Close remote debugger'} onPress={() => NativeDevSettings.setIsDebuggingRemotely(false)} />
</>
)
}
10 changes: 0 additions & 10 deletions packages/debugger-app/.eslintrc.cjs

This file was deleted.

4 changes: 0 additions & 4 deletions packages/debugger-app/.prettierrc.cjs

This file was deleted.

27 changes: 0 additions & 27 deletions packages/debugger-app/CHANGELOG.md

This file was deleted.

32 changes: 0 additions & 32 deletions packages/debugger-app/README.md

This file was deleted.

10 changes: 0 additions & 10 deletions packages/debugger-app/babel.config.cjs

This file was deleted.

2 changes: 0 additions & 2 deletions packages/debugger-app/index.d.ts

This file was deleted.

3 changes: 0 additions & 3 deletions packages/debugger-app/index.js

This file was deleted.

54 changes: 0 additions & 54 deletions packages/debugger-app/package.json

This file was deleted.

49 changes: 0 additions & 49 deletions packages/debugger-app/public/index.html

This file was deleted.

Binary file removed packages/debugger-app/src/assets/blue-icon.png
Binary file not shown.
Binary file removed packages/debugger-app/src/assets/gray-icon.png
Binary file not shown.
Binary file removed packages/debugger-app/src/assets/orange-icon.png
Binary file not shown.
Loading