fix: get host component names on render (modified) #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjastrzebski
requested review from
pierrezimmermannbam,
MattAgn and
AugustinLF
mdjastrzebski
changed the title
MattAgn
reviewed
Feb 4, 2023
MattAgn
reviewed
Feb 4, 2023
MattAgn
approved these changes
Feb 4, 2023
|
@pierrezimmermannbam @MattAgn In order to simplify code, reduce error handling I've added back lazy detection to |
Codecov ReportBase: 95.13% // Head: 96.07% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1306 +/- ##
==========================================
+ Coverage 95.13% 96.07% +0.93%
==========================================
Files 46 49 +3
Lines 3205 3308 +103
Branches 483 497 +14
==========================================
+ Hits 3049 3178 +129
+ Misses 156 130 -26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MattAgn
approved these changes
Feb 8, 2023
pierrezimmermannbam
approved these changes
Feb 8, 2023
|
well done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #1304, but since that was external PR I've moved it as internal repo PR with added proposed changes:
detectHostElementNamesfromgetHostComponents()configureHostElementNamesIfNeededto be called inrendergetHostElementNames.Summary
Fixes #1302 by detecting host component names in
renderto prevent running auto detection in externalactwhich fails for some users.Test plan
Added a test case where I call getHostComponentNames wrapped in act after a render and expect it does not throw