Skip to content

Commit

Permalink
feat: bump node version to 18 (#418)
Browse files Browse the repository at this point in the history
### Summary

This bumps the node version of the project to `v18.12.0`(18 LtS)

#### Why?

1. Node.js 16 LTS is coming to end-of-life later this year.
[Source](https://nodejs.org/en/blog/announcements/nodejs16-eol)
2. You are not able to install the dependencies of react native example
app anymore. It raises the following error:
```
error metro-config@0.77.0: The engine "node" is incompatible with this module. Expected version ">=18". Got "16.18.1"
```

### Test plan

As this doesn't add any feature, we need to make sure the core
functionality is not broken and all the CI checks pass.

---------

Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
  • Loading branch information
atlj and satya164 authored Jul 12, 2023
1 parent 2fe844a commit 7fa4a76
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.18.1
v18
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ const PACKAGES_TO_ADD_DEV = {
};

const PACKAGES_TO_ADD_WEB = {
'react-dom': '18.1.0',
'react-native-web': '~0.18.9',
'react-dom': '18.2.0',
'react-native-web': '~0.18.10',
};

const PACKAGES_TO_ADD_WEB_DEV = {
'@expo/webpack-config': '^0.17.2',
'@expo/webpack-config': '^18.0.1',
'babel-loader': '^8.1.0',
};

Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.18.1
v18

0 comments on commit 7fa4a76

Please sign in to comment.