Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Given texts are rendered conditionally now. #40

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

sardok
Copy link
Contributor

@sardok sardok commented Aug 2, 2020

Updated default values of text1 & text2 to undefined.

The omitted texts won't take space. Caller may optionally pass empty string if still needs related text's layout.

Copy link
Owner

@calintamas calintamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @sardok , thanks for your contribution!

@calintamas calintamas merged commit 8abe8a2 into calintamas:master Aug 14, 2020
@calintamas
Copy link
Owner

@sardok published in v1.3.2

@sardok sardok deleted the conditional-texts branch August 17, 2020 19:57
@sardok
Copy link
Contributor Author

sardok commented Aug 17, 2020

@sardok published in v1.3.2

Thanks.

remcorakers pushed a commit to remcorakers/react-native-toast-message that referenced this pull request Mar 15, 2023
Given texts are rendered conditionally now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants