increase the threshold to register a swipe on the toast container #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great library by the way, thanks for making it! |
calintamas
requested changes
Feb 9, 2021
calintamas
approved these changes
Feb 10, 2021
remcorakers
pushed a commit
to remcorakers/react-native-toast-message
that referenced
this pull request
Mar 15, 2023
…lintamas#144) * increase the threshold to register a swipe on the toast container * extract logic as to whether pan responder should respond to a gesture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to the fix for issue #113
I noticed when carrying out some testing on our app that presses weren't passing through correctly on Samsung devices. I managed to find the issue was to do with the threshold for registering pan / swipe events.
Super minor fix, increasing the threshold slightly and adding in a
onMoveShouldSetPanResponderCaptureequivalent methods meant it worked consistently across all the devices we tested on.