Update typings definitions #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferyjxn
approved these changes
Jan 14, 2021
calintamas
requested changes
Jan 14, 2021
There was a problem hiding this comment.
@sapieneptus thank you! added a comment, let me know what you think
This reverts commit 2983865.
remcorakers
pushed a commit
to remcorakers/react-native-toast-message
that referenced
this pull request
Mar 15, 2023
* extend type definitions * make properties optional * use TextStyle * try to make toast type generic * revert ToastConfig#type inference; fix text style * use TextStyle instead of TextPropTypes.style * Revert "use TextStyle instead of TextPropTypes.style" This reverts commit 2983865. * use Text.propTypes.style instead of TextPropTypes.style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working in TypeScript and noticed some of the type information seemed to be missing from index.d.ts.
I've added a few of the missing bits, but I'm sure there are others. Still, adding this much has been helpful to me.