feat(core): identity aliases #1094
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petarjuki7
requested review from
alenmestrov,
MatejVukosav,
miraclx,
fbozic and
frdomovic
miraclx
reviewed
Feb 4, 2025
miraclx
reviewed
Feb 5, 2025
MatejVukosav
reviewed
Feb 5, 2025
MatejVukosav
reviewed
Feb 5, 2025
miraclx
reviewed
Feb 7, 2025
crates/primitives/src/alias.rs
Outdated
Comment on lines
55
to
56
| .ok_or(InvalidAlias( | ||
| "alias exceeds maximum length of 50 characters", |
There was a problem hiding this comment.
why not make this into an enum variant?
|
|
||
| #[derive(Clone, Copy, Debug, Eq, Ord, PartialEq, PartialOrd)] | ||
| #[cfg_attr(feature = "borsh", derive(BorshSerialize, BorshDeserialize))] | ||
| pub struct IdentityAlias(Key<(Kind, Scope, Alias)>); |
There was a problem hiding this comment.
this shouldn't be named IdentityAlias since it may represent context, identity or application
There was a problem hiding this comment.
I agree, my logic was "Identity" in the sense it could be context identity, application identity, identity...
Do you have any suggestions?
HashAlias? NameAlias?
There was a problem hiding this comment.
Suggested change
| pub struct IdentityAlias(Key<(Kind, Scope, Alias)>); | |
| pub struct Alias(Key<(Kind, Scope, Name)>); |
E2E tests reportScenario: kv-store
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce aliases for user identities and context id's
Test plan
TBD
Documentation update
Will need docs and e2e test updates.