Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision update #4

Merged
merged 8 commits into from
Oct 8, 2024
Merged

Revision update #4

merged 8 commits into from
Oct 8, 2024

Conversation

johli
Copy link
Collaborator

@johli johli commented Oct 7, 2024

Description of your changes

  • Added new sh script to setup multi-fold data directories (TFRecord symlinks).
  • Updated all sh scripts (data processing / training / eval / QTLs / CRISPR).
  • Updated scripts / notebooks for aggregating replicate gradient scores for fold 3 (multiple crosses).
  • Moved data processing scripts/Makefile for published model from 'borzoi' repo to this repo.
  • Added sub-directory READMEs with more documentation about model training / data processing / evaluation.
  • Updated README with recommended usage instructions.

Type of change

  • Bug fix
  • New feature
  • Refactoring / code clean-up
  • Documentation add / update

(If applicable) How has this been tested?

Tests:

  • Re-ran all scripts from 'borzoi-paper' repo and 'borzoi' tutorials.
  • Checked that all major results from the paper reproduced (test evals, e/s/paQTLs).

Environment:

  • Python 3.10
  • TensorFlow 2.15

@johli johli requested review from davek44 and lruizcalico October 7, 2024 16:24
@johli johli self-assigned this Oct 7, 2024
Copy link

@davek44 davek44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just going to trust you on this one :)
Let me know if there's anything in particular you want me to look at.

@johli johli merged commit b107b4f into main Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants