Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error detecting version and testing workflow #19

Merged
merged 11 commits into from
Dec 19, 2024
Merged

Conversation

rly
Copy link
Collaborator

@rly rly commented Dec 18, 2024

The latest run has an error getting the version from source vcs. Fixing that resulted in errors finding the test data and the tests. This PR resolves those issues.

@rly rly changed the title Fix error detecting version Fix error detecting version and testing workflow Dec 18, 2024
@rly rly marked this pull request as ready for review December 18, 2024 23:59
@rly rly requested a review from calderast December 18, 2024 23:59
@rly
Copy link
Collaborator Author

rly commented Dec 19, 2024

The GitHub Action workflow is running correctly now. The tests are failing because of the updates to the ephys tests and channel map.

@calderast I suggest you squash and merge these commits so they don't clutter the commit history, but up to you.

Copy link
Owner

@calderast calderast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! We'll sort out the failing tests when we fix the channel maps

@calderast calderast merged commit a243a04 into main Dec 19, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants