Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make new copy localizable #17207

Merged
merged 6 commits into from
Oct 21, 2024
Merged

refactor: make new copy localizable #17207

merged 6 commits into from
Oct 21, 2024

Conversation

mfranzke
Copy link
Contributor

What does this PR do?

Based on #17198 making the new copy localizable.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox. -> N/A
  • I confirm automated tests are in place that prove my fix is effective or that my feature works. -> N/A

How should this be tested?

  • environment independent

Checklist

  • I haven't checked if my changes generate no new warnings

base on calcom#17198 making the new copy localizable
Copy link

vercel bot commented Oct 20, 2024

@mfranzke is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added ui area: UI, frontend, button, form, input 🐛 bug Something isn't working labels Oct 20, 2024
@mfranzke mfranzke changed the title refactor: make this localizable refactor: make new copy localizable Oct 20, 2024
@mfranzke mfranzke marked this pull request as ready for review October 20, 2024 20:50
@dosubot dosubot bot added i18n area: i18n, translations 💻 refactor labels Oct 20, 2024
@graphite-app graphite-app bot requested a review from a team October 20, 2024 20:50
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Oct 20, 2024
Copy link

graphite-app bot commented Oct 20, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (10/20/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/21/24)

1 label was added to this PR based on Keith Williams's automation.

@Praashh
Copy link

Praashh commented Oct 20, 2024

Hey @mfranzke , thanks for contributing but it seems like, this issue is fixed here #17198 P

@mfranzke
Copy link
Contributor Author

Hey @mfranzke , thanks for contributing but it seems like, this issue is fixed here #17198 P

Hey @Praashh, thanks a lot for coming back to this aspect. How are the english phrases ("Previous Month" and "Previous Month") being introduced with #17198 possible to get localized so that we won't have them rendered in a non-english-context of our application ?

@Praashh
Copy link

Praashh commented Oct 20, 2024

Hey @mfranzke , thanks for contributing but it seems like, this issue is fixed here #17198 P

Hey @Praashh, thanks a lot for coming back to this aspect. How are the english phrases ("Previous Month" and "Previous Month") being introduced with #17198 possible to get localized so that we won't have them rendered in a non-english-context of our application ?

Thanks a lot, @mfranzke for letting me know about this, I'll check it.

anikdhabal
anikdhabal previously approved these changes Oct 21, 2024
@anikdhabal anikdhabal enabled auto-merge (squash) October 21, 2024 05:36
Copy link
Contributor

github-actions bot commented Oct 21, 2024

E2E results are ready!

@anikdhabal anikdhabal merged commit 59aff41 into calcom:main Oct 21, 2024
33 of 37 checks passed
@mfranzke mfranzke deleted the patch-2 branch October 21, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync i18n area: i18n, translations ready-for-e2e 💻 refactor ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accessibility: missing textual description for buttons
3 participants