-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make new copy localizable #17207
Conversation
base on calcom#17198 making the new copy localizable
@mfranzke is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/20/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (10/20/24)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (10/21/24)1 label was added to this PR based on Keith Williams's automation. |
Hey @Praashh, thanks a lot for coming back to this aspect. How are the english phrases ("Previous Month" and "Previous Month") being introduced with #17198 possible to get localized so that we won't have them rendered in a non-english-context of our application ? |
Thanks a lot, @mfranzke for letting me know about this, I'll check it. |
E2E results are ready! |
What does this PR do?
Based on #17198 making the new copy localizable.
Mandatory Tasks (DO NOT REMOVE)
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.-> N/AI confirm automated tests are in place that prove my fix is effective or that my feature works.-> N/AHow should this be tested?
Checklist