perf: Remove tRPC event call from server-side props #17205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
performance
keithwillcode
commented
Oct 20, 2024
| ): Promise<string | undefined> { | ||
| const eventTypeMetadataQuery = await prisma.eventType.findUnique({ |
There was a problem hiding this comment.
Removed this extra roundtrip to the DB to get the metadata since we already had it.
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (10/20/24)1 reviewer was added to this PR based on Keith Williams's automation. |
E2E results are ready! |
zomars
previously approved these changes
Oct 20, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
zomars
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is broken off from #17194 (credit to @emrysal) since that PR is in draft and has a bunch of typing errors + it's more widespread changes. Keeping this isolated so we can test the difference in perf.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?