Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Single query user enrichment calls by array of userIds instead #17190

Merged
merged 3 commits into from
Oct 19, 2024
Merged

perf: Single query user enrichment calls by array of userIds instead #17190

merged 3 commits into from
Oct 19, 2024
+114 −21

Conversation

alishaz-polymath
Copy link
Member

@alishaz-polymath alishaz-polymath commented Oct 19, 2024 •
edited by Udit-takkar
Loading

What does this PR do?

TODO: Add Benchmarks

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Oct 19, 2024
Udit-takkar
Udit-takkar reviewed Oct 19, 2024
View reviewed changes
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine

@vercel Vercel
Copy link

vercel bot commented Oct 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2024 4:56pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2024 4:56pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 19, 2024 •
edited
Loading

E2E results are ready!

@Udit-takkar Udit-takkar marked this pull request as ready for review October 19, 2024 17:55
@dosubot dosubot bot added the performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive label Oct 19, 2024
@keithwillcode keithwillcode added this to the v4.7 milestone Oct 19, 2024
@keithwillcode keithwillcode merged commit f70e8c5 into main Oct 19, 2024
83 of 84 checks passed
@keithwillcode keithwillcode deleted the perf/single-query-for-enrich-userprofiles branch October 19, 2024 22:17
keithwillcode pushed a commit that referenced this pull request Oct 20, 2024
@alishaz-polymath @Udit-takkar @keithwillcode
perf: Single query user enrichment calls by array of userIds instead (#…
182b3d9 
…17190)

* single query

* getPublicEvent

* perf: use Map for faster lookup for large objects

---------

Co-authored-by: Udit Takkar <udit222001@gmail.com>
@keithwillcode keithwillcode mentioned this pull request Oct 20, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Udit-takkar Udit-takkar Udit-takkar left review comments

@keithwillcode keithwillcode keithwillcode approved these changes

Assignees
No one assigned
Labels
core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive ready-for-e2e
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.
3 participants
@alishaz-polymath @keithwillcode @Udit-takkar