Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase pagination managed users endpoint #17147

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

ThyMinimalDev
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev commented Oct 17, 2024

What does this PR do?

Increase pagination to fetch managed users

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@dosubot dosubot bot added the platform Anything related to our platform plan label Oct 17, 2024
@keithwillcode keithwillcode added the core area: core, team members only label Oct 17, 2024
@ThyMinimalDev ThyMinimalDev enabled auto-merge (squash) October 17, 2024 14:10
@graphite-app graphite-app bot requested a review from a team October 17, 2024 14:10
Copy link

graphite-app bot commented Oct 17, 2024

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (10/17/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/17/24)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

E2E results are ready!

@ThyMinimalDev ThyMinimalDev merged commit 8b50f41 into main Oct 17, 2024
43 of 83 checks passed
@ThyMinimalDev ThyMinimalDev deleted the increase-pagination-managed-users branch October 17, 2024 14:32
hariombalhara added a commit that referenced this pull request Oct 18, 2024
…ogic (#17154)

* chore: increase pagination managed users endpoint (#17147)

* Add server-timings and used concurrency 2 for teamMembers matching

---------

Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>
hariombalhara added a commit that referenced this pull request Oct 18, 2024
* chore: increase pagination managed users endpoint (#17147)

* Log timings

---------

Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>
PeerRich pushed a commit that referenced this pull request Oct 18, 2024
* chore: increase pagination managed users endpoint (#17147)

* Dont reuse the existing modal

---------

Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>
hariombalhara added a commit that referenced this pull request Oct 18, 2024
* chore: increase pagination managed users endpoint (#17147)

* perf: Build tree once per call

---------

Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>
hariombalhara added a commit that referenced this pull request Oct 20, 2024
* chore: increase pagination managed users endpoint (#17147)

* Add fallbackSchedule and troubleshooter data

* Disable troubleshooter by default

* Improve slots existence assertion

---------

Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>
Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants