Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass from org link to all instances of event.public #17136

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

sean-brydon
Copy link
Member

What does this PR do?

Fixes the issue where the duplicate call of event.public.useQuery had different query params due to a missing parameter.

This fix should reduce the call time of this endpoint in booker by 50% as we don't need to double fetch the main bulk of data

How should this be tested?

Load a public event and notice that the call only fires one event and they are not batched

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app bot requested a review from a team October 16, 2024 11:57
@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working labels Oct 16, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Oct 16, 2024
Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 0:31am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 0:31am

Copy link

graphite-app bot commented Oct 16, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/16/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/16/24)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

Copy link
Contributor

E2E results are ready!

@sean-brydon sean-brydon merged commit e949a4c into main Oct 16, 2024
58 of 59 checks passed
@sean-brydon sean-brydon deleted the feat/fix-event-batching branch October 16, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working consumer core area: core, team members only ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants