Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added custom class name to booker and availability atom #17105

Merged
merged 10 commits into from
Oct 16, 2024
Merged

feat: added custom class name to booker and availability atom #17105

merged 10 commits into from
Oct 16, 2024

Conversation

SomayChauhan
Copy link
Member

@SomayChauhan SomayChauhan commented Oct 15, 2024 •
edited
Loading

What does this PR do?

  • Added a className prop to the AtomsWrapper component.

  • The className prop is optional and allows users to apply their own custom styles.

  • added props to availability atom -

    • allowDelete
    • allowSetToDefault
    • added customClassNames -> hiddenSwitchClassname, deleteButtonClassname

  • Fixes #XXXX (GitHub issue number)

  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app bot requested a review from a team October 15, 2024 07:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "added custom class name for booker atoms wrapper `atomsWrapper`". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Oct 15, 2024
@dosubot dosubot bot added the ✨ feature New feature or request label Oct 15, 2024
@graphite-app graphite-app bot requested a review from a team October 15, 2024 07:48
@graphite-app Graphite App
Copy link

graphite-app bot commented Oct 15, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/15/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (10/15/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@SomayChauhan SomayChauhan changed the title added custom class name for booker atoms wrapper atomsWrapper feat: added custom class name for booker atoms wrapper atomsWrapper Oct 15, 2024
@SomayChauhan
added props to availability atom
8cf1720 
* allowDelete
* allowSetToDefault
* added customClassNames -> hiddenSwitchClassname, deleteButtonClassname
@vercel Vercel
Copy link

vercel bot commented Oct 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 11:44am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 11:44am

@SomayChauhan SomayChauhan changed the title feat: added custom class name for booker atoms wrapper atomsWrapper feat: added custom class name for booker atom and availability atom Oct 15, 2024
@SomayChauhan SomayChauhan changed the title feat: added custom class name for booker atom and availability atom feat: added custom class name to booker and availability atom Oct 15, 2024
@ThyMinimalDev ThyMinimalDev enabled auto-merge (squash) October 16, 2024 11:44
@ThyMinimalDev ThyMinimalDev merged commit 64b321a into main Oct 16, 2024
38 checks passed
@ThyMinimalDev ThyMinimalDev deleted the add-custom-classname-to-booker-atom-wrapper branch October 16, 2024 12:04
@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThyMinimalDev ThyMinimalDev ThyMinimalDev approved these changes

Assignees
No one assigned
Labels
core area: core, team members only ✨ feature New feature or request platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SomayChauhan @ThyMinimalDev @keithwillcode