Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue chargin no show fee #17066

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Conversation

anikdhabal
Copy link
Contributor

@anikdhabal anikdhabal commented Oct 11, 2024

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A-I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A-I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Copy link

vercel bot commented Oct 11, 2024

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Oct 11, 2024
@graphite-app graphite-app bot requested a review from a team October 11, 2024 11:52
@keithwillcode keithwillcode added the community-interns The team responsible for reviewing, testing and shipping low/medium community PRs label Oct 11, 2024
@dosubot dosubot bot added payments Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Oct 11, 2024
Copy link

graphite-app bot commented Oct 11, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (10/11/24)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

@joeauyeung joeauyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find @anikdhabal. I notice we're not handling if the user has a personal payment credential and a team one. We should only query for the team payment credentials for bookings made on team events.

Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see @joeauyeung feedback was addressed. Looks good to merge now

@zomars zomars enabled auto-merge (squash) October 15, 2024 14:43
@zomars zomars dismissed joeauyeung’s stale review October 15, 2024 14:43

feedback addressed

@zomars zomars merged commit c6f84e6 into calcom:main Oct 15, 2024
51 of 58 checks passed
Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync community-interns The team responsible for reviewing, testing and shipping low/medium community PRs payments Created by Linear-GitHub Sync ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants