Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use userPhone instead of phone for switch case #16384

Merged
merged 3 commits into from
Aug 28, 2024
Merged

fix: use userPhone instead of phone for switch case #16384

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f4d0da
fix: use `userPhone` instead of `phone` for switch case
nicmosc Aug 28, 2024
fdb5fea
fix another case
anikdhabal Aug 28, 2024
af0de07
Merge branch 'main' into patch-2
CarinaWolli Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/platform/atoms/event-types/atom-api-transformers/transformApiEventTypeForAtom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,11 +190,11 @@ function getLocations(locations: EventTypeOutput_2024_06_14["locations"]) {
const { displayLocationPublicly, type } = location;

switch (type) {
case "address":
case "inPerson":
return displayLocationPublicly ? location : { ...location, address: "" };
case "link":
return displayLocationPublicly ? location : { ...location, link: "" };
case "phone":
case "userPhone":
Copy link
Contributor

@anikdhabal anikdhabal Aug 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good observation. That's correct. I think the case "address" is also wrong; it should be case "inPerson"

cal.com/packages/lib/event-types/transformers/api-request.ts

Line 33 in bd410cf

return { type: "inPerson", address: location.address, displayLocationPublicly: location.public };

return displayLocationPublicly
? location
: {
Expand Down
Loading