feat: ability to add guests via app.cal.com/bookings #14740
Conversation
|
@anikdhabal is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
github-actions
bot
added
booking-page
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Eighty-five Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
dosubot
bot
added
the
bookings
Graphite Automations"Add community label" took an action on this PR • (04/29/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (04/29/24)1 reviewer was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
Hi @anikdhabal,
Great job! I have a few recommendations, let me know what you think:
-
– I'm not sure this is the right email to send to the person we just invited.
-
In this video (https://www.loom.com/share/a265d095174149fb9d551227f3dd42ee?sid=5bad974f-6453-49e4-bd36-1fbe9504701e), I noticed that the first email includes the cal-video link, but the subsequent emails do not.
Hello @SomayChauhan , thanks for the review. Can you explain the first recommendation? |
https://www.loom.com/share/5978b488df724862ad8f340a651172de?sid=1f96fb9f-3844-4183-8aeb-698953e04b3e for the ones that were already were part of the event, |
|
I've made changes, and the second recommendation is working fine for me with any other conference app. I think it is a Cal Videos internal error. |
There was a problem hiding this comment.
LGTM 💯
can handle the rest while implementing #15663
will wait for one more approval
SomayChauhan
dismissed
their stale review
anik to make some changes that we discussed over on the call
dosubot
bot
added
the
emails
Thanks for pointing this out. I’ve fixed it. |
E2E results are ready! |
What does this PR do?
Fixes #14691
Fixes #15663
Bookings._.Cal.com.and.6.more.pages.-.Personal.-.Microsoft_.Edge.2024-04-30.03-39-02.mp4