Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shell): maximize respect height of active screen #118

Closed
wants to merge 1 commit into from

Conversation

mickedefault
Copy link
Collaborator

this pr introduces the prerelease of https://github.com/microsoft/CsWin32 for sourcegenerating pinvoke commands.
the methods that are to be pinvoked are defined in the NativeMethods.txt file in the gitout folder.

we need to be willing to use this and also be aware of for instance this thread if we want to merge this pr

@mickedefault mickedefault added the fix Something wasn't working label Mar 21, 2021
@mickedefault mickedefault requested a review from calahatras March 21, 2021 22:47
@mickedefault mickedefault linked an issue Mar 21, 2021 that may be closed by this pull request
@mickedefault mickedefault force-pushed the bug/active-screen-maxheight branch from 10d34a8 to bcd7a09 Compare March 22, 2021 19:39
@mickedefault mickedefault force-pushed the bug/active-screen-maxheight branch from bcd7a09 to 9135173 Compare March 22, 2021 20:00
@mickedefault
Copy link
Collaborator Author

resolves go-3

@calahatras
Copy link
Owner

Close in favor of https://gitout.myjetbrains.com/youtrack/issue/go-85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Something wasn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maxheight does not respect active screen
2 participants