Fix changing boolean column option's in postgresql #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
MasterOdin
force-pushed
the
mpeveler/bugfix-postgresql-boolean
branch
from
57bb1ea to
0c060ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2017
This PR fixes a regression introduced in #1974 where attempting to edit a boolean column's options would cause an exception. This exception is caused where as part of setting the default value
#1974 introduced a regression where attempting to edit any boolean option would cause an exception to be thrown due to invalid comparison where we tried to do
column_name=0as postgresql does not recognizeboolean = integercomparisons. To fix it, we add a cast on the column to integer before doing the comparison, which works fine on boolean columns. On this, the PR fixes a secondary bug where null values in columns being converted to boolean would have null values casted totrue.