Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FormProtectionException #18015

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Nov 7, 2024

This exception is now used by FormProtectionComponent when request validation fails. This allows to filter out the exception when logging errors.

This exception is now used by FormProtectionComponent when request
validation fails. This allows to filter out the exception when logging errors.
@ADmad ADmad added this to the 5.2.0 milestone Nov 7, 2024
@ADmad ADmad force-pushed the feat/5.2-form-protection-exception branch 2 times, most recently from 71732ba to 67cd13b Compare November 7, 2024 11:29
/**
* Security exception - used when SecurityComponent detects any issue with the current request
*/
class SecurityException extends BadRequestException
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could break applications. While I don't think that applications should be using this exception they could be using it. Perhaps we should leave this in and add a deprecation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ADmad ADmad force-pushed the feat/5.2-form-protection-exception branch from 67cd13b to c59aa8d Compare November 9, 2024 06:45
@markstory markstory merged commit 81ec941 into 5.next Nov 11, 2024
12 of 13 checks passed
@markstory markstory deleted the feat/5.2-form-protection-exception branch November 11, 2024 04:59
markstory added a commit to cakephp/docs that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants