Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cake.UrlLoadDirective.Module.yml #1883

Conversation

cake-contrib-bot
Copy link
Contributor

This pull request was created by a tool: Cake.AddinDiscoverer version 3.71.0

Resolves #1882

@augustoproiete
Copy link
Member

Jericho added 2 commits March 29, 2021 09:46
Add the missing quotes and restore the part of the description that was previously interpreted as a comment (due to the presence of `#` combined with missing quotes)
@Jericho
Copy link
Contributor

Jericho commented Mar 29, 2021

AddinDiscoverer was improved to properly "quote" strings in YAML files. I have manually restored the part of the description that was cut-off after the # character and added quotes to ensure that # is no longer treated as a symbol for comments.

@Jericho Jericho removed blocked upstream merge blocked PR should not be merged yet labels Mar 29, 2021
Copy link
Contributor

@Jericho Jericho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@augustoproiete augustoproiete enabled auto-merge (squash) March 29, 2021 13:54
@augustoproiete augustoproiete merged commit 687e11a into cake-build:master Mar 29, 2021
@Jericho Jericho deleted the update_Cake.UrlLoadDirective.Module.yml_2021_03_20_12_04_34 branch March 29, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Cake.UrlLoadDirective.Module.yml
3 participants