Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode is no longer supporting specifiying a commandId in the "initialConfigurations" contribution #59

Closed
isidorn opened this issue Nov 6, 2017 · 7 comments
Assignees
Milestone

Comments

@isidorn
Copy link

isidorn commented Nov 6, 2017

Hi,

We noticed your extension in package.json is using a "initialConfigurations" contribution in a deprecated way by specifiying a command id.
We wanted to let you know that we plan to delete support for this specific use of "initialConfigurations" soon.
More about this deprecation can be found here and in our release notes.
A good example on how to use the DebugConfigurarationProvider which is the new way of doing this can be found here

Kind regards,
Isidor from the VSCode team

@gep13
Copy link
Member

gep13 commented Nov 6, 2017

@isidorn thank you for raising this, we were initially tracking this here: #54, but I will close that one as a duplicate.

@gep13 gep13 self-assigned this Nov 6, 2017
@gep13 gep13 added this to the 0.10.0 milestone Nov 6, 2017
@gep13
Copy link
Member

gep13 commented Nov 6, 2017

@isidorn would you be in a position to provide some help with this? I am trying to implement the DebugConfigurationProvider but neither the provideDebugConfigurations or resolveDebugConfiguration methods are called. At which point should I expect these to be called in order to return my initial configurations? Thanks!

@gep13
Copy link
Member

gep13 commented Nov 6, 2017

@isidorn actually, I think I have figured this out, as we are not using the full API surface. Could you please verify the changes in this PR: #62

Thanks in advance!

@isidorn
Copy link
Author

isidorn commented Nov 7, 2017

@gep13 I suggest that you simply try your extension against the latest vscode insiders. If it works then I would be confident of the changes.
I glanced through your code in the PR and I do not see any implementation of the DebugConfigurationProvider which I find strange.

@gep13
Copy link
Member

gep13 commented Nov 7, 2017

@isidorn thanks for taking the time to look at this! I really appreciate it!

I have ran the code in the Insiders build of code, and it seems to work as I would expect it to.

This extension doesn't actually add anything other than the contents of the launch.json file. This comes in two forms, i.e. when the user presses F5 when there is no launch.json file in the workspace, it provides an initialConfiguration for either Cake CoreCLR or Cake Mono. If there is already a launch.json file, then we provide some configurationSnippets to allow them to add a new entry for either of the above.

And that is it. We aren't doing anything else as the configuration are either simply shelling out to the coreclr or mono debugger, neither of which are provided by this extension.

As a result, I didn't seem to need to implement the DebubConfigurationProvider, as both of these items can be provided via the packages.json file.

Does that make sense, or have I done something silly?

@isidorn
Copy link
Author

isidorn commented Nov 7, 2017

@gep13 if it works fine then all is good. DebugConfigurationProvider is there only if you need to specially massage the launch.json configurations. If everythign works nicely staticly then just leave it as a contribution in package.json

@gep13
Copy link
Member

gep13 commented Nov 7, 2017

@isidorn ok perfect, in which case, I think we can leave it as is, as we don't do any special handling of the launch.json (or at least, not yet 😄).

Thanks again for reaching out on this issue!

gep13 added a commit that referenced this issue Nov 7, 2017
@gep13 gep13 closed this as completed Nov 7, 2017
gep13 added a commit that referenced this issue Nov 7, 2017
* release/0.10.0:
  (GH-60) Added cake.config as ini file
  (build) Trying to fix AppVeyor build
  (GH-59) Changes for new Debug API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants