Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to support fully qualified table names #5

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Fix to support fully qualified table names #5

merged 1 commit into from
Jul 14, 2022

Conversation

simelis
Copy link
Contributor

@simelis simelis commented Jul 13, 2022

The code is currently throwing "Invalid object name {TableName}" exception when fully qualified table name with non default schema is used. This PR fixes it.

cajuncoding
cajuncoding approved these changes Jul 14, 2022
View reviewed changes
Copy link
Owner

@cajuncoding cajuncoding left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Enhancements... clean expansion of existing model and it makes sense to use the Fully Qualified Name whenever possible.

Thanks for not only reporting the issue but providing a Fix! 👏 👏 👏

@cajuncoding cajuncoding merged commit ff9fa0a into cajuncoding:main Jul 14, 2022
@cajuncoding
Copy link
Owner

cajuncoding commented Jul 14, 2022 •
edited
Loading

Ok, it's now merged and published as an updated version v1.2 to Nuget 👍

Smoke tests have passed....
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cajuncoding cajuncoding cajuncoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simelis @cajuncoding