Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizations #94

Merged
merged 9 commits into from
Oct 19, 2018
Merged

Optimizations #94

merged 9 commits into from
Oct 19, 2018

Conversation

caiyue1993
Copy link
Owner

This PR includes:

  1. Fetch changes on the non-main thread
  2. Add pushAll method
  3. Move registerLocalDatabase to completion block of createCustomZones
  4. Change method name sync to pull
  5. Fix isCustomZoneCreated setter logic
  6. More Swift 4.2 and optimize code style

@caiyue1993 caiyue1993 merged commit 787f2c0 into master Oct 19, 2018
@caiyue1993 caiyue1993 deleted the refactor/optimize branch October 19, 2018 16:03
This was referenced Oct 19, 2018
Closed
Closed
Closed
@bitomule
Copy link
Contributor

Great work @caiyue1993 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caiyue1993 @bitomule