fix(ngResource): don't append number to '$' in url param value when e…

…ncoding URI

Previously, if a URL parameter value included a $, it would replace the dollar sign with a literal
'$1' for mysterious reasons. Using a function rather than a replacement string circumvents this
behaviour and produces a more expected result.

Closes angular#6003

src/ngResource/resource.js

@@ -387,7 +387,9 @@ angular.module('ngResource', ['ng']).
           val = params.hasOwnProperty(urlParam) ? params[urlParam] : self.defaults[urlParam];
           if (angular.isDefined(val) && val !== null) {
             encodedVal = encodeUriSegment(val);
-            url = url.replace(new RegExp(":" + urlParam + "(\\W|$)", "g"), encodedVal + "$1");
+            url = url.replace(new RegExp(":" + urlParam + "(\\W|$)", "g"), function(match, p1) {
+              return encodedVal + p1;
+            });
           } else {
             url = url.replace(new RegExp("(\/?):" + urlParam + "(\\W|$)", "g"), function(match,
                 leadingSlashes, tail) {
@@ -399,7 +401,7 @@ angular.module('ngResource', ['ng']).
             });
           }
         });
-
+   
         // strip trailing slashes and set the url
         url = url.replace(/\/+$/, '') || '/';
         // then replace collapse `/.` if found in the last URL path segment before the query
@@ -408,7 +410,6 @@ angular.module('ngResource', ['ng']).
         // replace escaped `/\.` with `/.`
         config.url = url.replace(/\/\\\./, '/.');
 
-
         // set params - delegate param encoding to $http
         forEach(params, function(value, key){
           if (!self.urlParams[key]) {

test/ngResource/resourceSpec.js

@@ -178,9 +178,11 @@ describe("resource", function() {
 
     $httpBackend.expect('GET', '/Path/foo%231').respond('{}');
     $httpBackend.expect('GET', '/Path/doh!@foo?bar=baz%231').respond('{}');
+    $httpBackend.expect('GET', '/Path/herp$').respond('{}');
 
     R.get({a: 'foo#1'});
     R.get({a: 'doh!@foo', bar: 'baz#1'});
+    R.get({a: 'herp$'});
   });